there is no await next() in a controller, it has no callback
Yip so that means we need to document this as normal beavoir
Since it is not fixable
Since I asume that after I called super.find() it changes the ctx
mmm yeah probably but we generally only document stuff that we implement or change, but no super.X methods don’t change anything
that’s basically just wrapping a middleware around the controller
How I see it middlewares do get the updated ctx.
because we update the middleware but yes
(we update some parts of it)
I agree but my expected behavior would be it updates the ctx. since it does that everywhere else.
Not entirely no, I wouldn’t expect the ctx to be updated because it hasn’t gone through the parser
parser is above controllers, below middlewares
As a user looking at the code I agree.
but as a normal strapi user I would not know that.
Because what you are returning isn’t directly updating the ctx, you are returning data to another function
(several layers of functions), ctx wouldn’t be updated until something strictly updates it
Again I agree but we should tell the user at what point the ctx gets updated in the chain but we don’t
Koa native doesn’t have the concept of controllers, services, ect it just has handlers and handlers don’t update the ctx til higher up on the return chain
what means users will make assumtions
I’ve never seen anyone raise this issue before, we cannot document every little tiny thing
it makes the docs extremely difficult to maintain