Simple one-to-one relation throws error

DMehaffy · October 2, 2020, 8:27pm

@mkirkland I’m sorry I am officially out of ideas, I’ve tested every single possible combination of OS, versions, and anything I can think of but the issue in this case absolutely isn’t with the project and it has to be on your end but I can’t for the life of me figure out why or what the cause is.

mkirkland · October 3, 2020, 2:45pm

I tried it as well with a sql-lite db and same error.

I also tried it on my Windows 10 laptop(strapi 3.1.7) with sql-lite and same error.

I then tried on my Windows Server 2016 Server with 24 cores and 96GB of Ram and same error with sql-lite.

I dont understand how this can only be happening to me and my machines. This makes no sense.

mkirkland · October 3, 2020, 3:18pm

Ok, so the FINAL test was on the official strapi digitalocean droplet.

I installed the OFFICIAL strapi DO droplet and tested it and it still breaks with the same error. I’d be glad to give the strapi dashboard admin creds for you to log in and see the error.

DMehaffy · October 3, 2020, 5:50pm

@mkirkland can you try to give me the exact steps when you create the relation to cause the error? (I built the one-click myself), even better if you can record a short gif video or something.

mkirkland · October 3, 2020, 6:38pm

I can record a video probably tomorrow but the steps are simple.

Spin up the droplet.
Create Format collection, with one field called name.
Create Ticket collection, with one field called name and one relation field. Relation is Ticket has one Format.
Create a new Format record.
Create a new Ticket record with a name and add the Format from the relation drop-down.
Once you click on save, the error occurs and never saves the ticket.

jesperordrup · October 4, 2020, 6:19am

Just a quick one - could it be the name “Format” is reserved ?

mkirkland · October 4, 2020, 3:43pm

You are a genius, that was the issue the whole time. Just tested it on my main machine as well as the DO droplet and it worked on both. Life saver

Is there a list somewhere of the reserved words?

jesperordrup · October 4, 2020, 5:10pm

I really enjoy being called a genius.

It would be nice if strapi checked for reserved words

DMehaffy · October 5, 2020, 2:53pm

better question is why that didn’t trigger any of my tests to fail. We do have a list:

github.com

strapi/strapi/blob/645c0b8cf4564adc0a12b01873201901ac85fab7/packages/strapi-database/lib/constants/index.js#L4-L36


      
          const RESERVED_MODEL_NAMES = ['admin', 'boolean', 'date', 'date-time', 'time', 'upload'];
          // attribute reserved names
          const RESERVED_ATTRIBUTE_NAMES = [
            '_id',
            'id',
            'length',
            'attributes',
            'relations',
            'changed',
            'created_by',
            'updated_by',
            '_posts', // list found here https://mongoosejs.com/docs/api.html#schema_Schema.reserved
            '_pres',
            'collection',
            'emit',
            'errors',
            'get',
            'init',
            'isModified',
            'isNew',

This file has been truncated. show original

Typically model names don’t trigger it, just field names

mkirkland · October 5, 2020, 3:23pm

Derrick, per that list of reserved words, “format” is not one of them. Maybe that’s something that needs to be added to that list.

DMehaffy · October 5, 2020, 3:24pm

Do you feel like making a pull request @mkirkland? (I’m gonna do another test right now just to confirm that is the issue.)

FYI as a workaround try using ticket format as the model name instead that should dump it out as a UID of ticket-format and the issue -should- go away.

DMehaffy · October 5, 2020, 3:44pm

It’s the field name format on the ticket model, managed to reproduce it! \o/

Here I was testing creating relation not data

@mkirkland do you want to try your hand at creating the PR or would you rather I do it?

mkirkland · October 5, 2020, 3:46pm

I can give a PR a shot later tonight, i’m at my day job right now

Or if you feel it’s urgent then you can go ahead and do it.

DMehaffy · October 5, 2020, 3:49pm

Nope not urgent, it won’t be merged right away so no rush. I’ll keep an eye out tmrw morning.